There are various opinions on welding cable vs. battery cable and also plenty of opinions on soldering vs. crimping.
None of the options in my opinion are actually "bad". Large cable of whichever type and however it is attached so long as it is secure is better than most of what you find for old cobbled together and wimpy/inappropriate battery cables.